Re: [htdig3-dev] Re: code changes to 3.2 vs 3.1.2


Gilles Detillieux (grdetil@scrc.umanitoba.ca)
Wed, 31 Mar 1999 15:56:00 -0600 (CST)


According to Geoff Hutchison:
> On Wed, 31 Mar 1999, Gilles Detillieux wrote:
> > additions as unobtrusive as possible, I never chose to reorganise anything.
> > I was just pointing out to Mike where the existing methods are, but yeah,
> > when you think about it, why is buildMatchList in Display.cc?
>
> My basic plan for the 3.1 release was to gather all the generally useful
> patches to 3.0.8, add a few new features, and clean up most of the bugs.
> So I was going for a minimalist approach.

3.0.8??? That must have been some spring break! ;-)

> My plan for 3.2 involves some major code changes, especially to the
> database code. Everyone should feel free to consider changes that move
> code, remove classes entirely, etc. Since I don't forsee 3.2 nearing
> completion for some time, we have the luxury of trying things and
> realizing they do or do not work as we expected.

Sounds good to me. I'd like to wrap up 3.1.2 before too long, because there
have been a lot of bug fixes since 3.1.1. I think I backported most non-DB
changes from 3.2 to 3.1.2 now, but there was the whole Makefile include
business that I wasn't sure about. If you think it's an appropriate
bug fix for 3.1.2, could you put it in?

Things like the date range selection and template_patterns idea discussed
a while back would be fore 3.2 only.

I was also wondering about this last change to htdig.cc in 3.1.2:

193c193,197
< l.Create(config["exclude_urls"], " \t");

---
>     if (strlen(config["exclude_urls"]) != 0)
>       l.Create(config["exclude_urls"], " \t");
>     else // Make sure we have *something*
>       l.Create("!~-no-urls-~!", " \t");
> 

Is there an advantage to doing this rather than testing excludes.hasPattern() before doing a excludes.FindFirst()? I was wondering why in some cases, one approach is used, and in other cases, another is used.

-- 
Gilles R. Detillieux              E-mail: <grdetil@scrc.umanitoba.ca>
Spinal Cord Research Centre       WWW:    http://www.scrc.umanitoba.ca/~grdetil
Dept. Physiology, U. of Manitoba  Phone:  (204)789-3766
Winnipeg, MB  R3E 3J7  (Canada)   Fax:    (204)789-3930
------------------------------------
To unsubscribe from the htdig3-dev mailing list, send a message to
htdig3-dev@htdig.org containing the single word "unsubscribe" in
the SUBJECT of the message.



This archive was generated by hypermail 2.0b3 on Wed Mar 31 1999 - 14:33:28 PST